examples: operationalization of the author disambiguation example

inspirehep / beard

Bibliographic Entity Automatic Recognition and Disambiguation

Other

66 stars 36 forks source link

examples: operationalization of the author disambiguation example #27

Closed glouppe closed 9 years ago

glouppe commented 9 years ago

[x] Add command line arguments for the advanced disambiguation example.
[x] Switch to JSON format for input/output (rather than pickles), allowing for an easier use in external contexts.
[x] Documentation.

glouppe commented 9 years ago

Okay, so the example is now properly working using JSON input/output format. I will document everything tomorrow so that you @natsheh and @MSusik can move on with your own analyses.

glouppe commented 9 years ago

Documentation is now complete. See https://github.com/glouppe/beard/blob/author-disambiguation-ops/examples/author_disambiguation_advanced.py#L55 for a description of the expected input format.

glouppe commented 9 years ago

Reviews are welcome :) @natsheh @MSusik @etzemis

MSusik commented 9 years ago

Clearer than previous version, :+1:

glouppe commented 9 years ago

Thanks for the review! @natsheh would you have time today for a second review? thanks

natsheh commented 9 years ago

Looks great! I just have not a critical suggestion: it may be more interesting to use "sklearn.externals.joblib"’s replacement of pickle (joblib.dump & joblib.load), which is more efficient on big data. I have noticed that on Windows enviroment, I cannot load the pickle dump file.