Adding silhouette_score for unsupervised thresholding

inspirehep / beard

Bibliographic Entity Automatic Recognition and Disambiguation

Other

66 stars 36 forks source link

Adding silhouette_score for unsupervised thresholding #34

Closed natsheh closed 9 years ago

natsheh commented 9 years ago

Hello @glouppe @MSusik @etzemis. Could you please review? Thanks.

glouppe commented 9 years ago

Thanks for making it a nice PR :) I'll try checking that tomorrow.

MSusik commented 9 years ago

Looks good to me!

glouppe commented 9 years ago

Thanks for refactoring the tests. It is much better like this :)

+1 for merge once my other comments are addressed.

natsheh commented 9 years ago

I have made some changes covering your feecback comments. The main changes were to fit with case of not passing any parameters except n_clusters or treshold. @glouppe can you please double check and approve the PR? Thanks.

glouppe commented 9 years ago

Thanks for the changes! Merging :beers: