search

inspirehep / beard

Bibliographic Entity Automatic Recognition and Disambiguation
Other
66 stars 36 forks source link

applications: initial release #49

Closed MSusik closed 9 years ago

MSusik commented 9 years ago

This addresses #48.

Signed-off-by: Mateusz Susik mateusz.susik@cern.ch

glouppe commented 9 years ago

Could you move the author disambiguation into examples/applications/author-disambiguation/ ? Eventually, there may be several applications built on beard.

Also, the application should not be part of beard/, since it is meant to be standalone.

MSusik commented 9 years ago

Also, the application should not be part of beard/, since it is meant to be standalone.

Then you won't be able to import it (as long as there is only one package).

glouppe commented 9 years ago

Then you won't be able to import it (as long as there is only one package).

Yes, and this is fine.

glouppe commented 9 years ago

Other than my comments regarding documentation, +1 for merge. Thanks for this work!

@natsheh Please review as well

MSusik commented 9 years ago

Should be better @glouppe @natsheh

natsheh commented 9 years ago

:+1:

glouppe commented 9 years ago

Closing in favor of #52