search

inspirehep / beard

Bibliographic Entity Automatic Recognition and Disambiguation
Other
66 stars 36 forks source link

general: prepare for release on PyPI #91

Closed jacquerie closed 8 years ago

jacquerie commented 8 years ago

Closes #79.

MSusik commented 8 years ago

:+1:

jacquerie commented 8 years ago

Ah, right : ) https://travis-ci.org/inspirehep/beard/jobs/124478805#L563

jacquerie commented 8 years ago

@MSusik, care for a review? I will take care of submitting it to PyPI.

kaplun commented 8 years ago

To me looks good! Was just wandering. When you install beard, the examples directory doesn't get installed. I wonder how the author-disambiguation app is currently used then within invenio-beard

glouppe commented 8 years ago

The philosophy was that beard is a library, not an application. Examples serve as documentation of what can be done with the library, but they are not part of it.

MSusik commented 8 years ago

@jacquerie Looks good

jacenkow commented 8 years ago

@kaplun invenio-beard and beard-server do not rely on examples.

kaplun commented 8 years ago

OK. @jacquerie :shipit:

kaplun commented 8 years ago

Can you actually write in commit log that it closes #79 :)

jacquerie commented 8 years ago

You can actually do it from a PR as well! https://github.com/blog/1506-closing-issues-via-pull-requests

On the other hand the presence of the dot in the end might be a problem. So I'll modify the commit to be safe : )

kaplun commented 8 years ago

Figo!

glouppe commented 8 years ago

Thanks for the last touches @jacquerie !

Shall we make a 0.2 release and ship that to PyPI?

kaplun commented 8 years ago

Why not directly this very version? :smiley:

jacquerie commented 8 years ago

Err... Did I do something wrong? https://pypi.python.org/pypi/beard appears to work, pip install beard appears to work, am I missing something?

jacquerie commented 8 years ago

Oh, I see! You actually already tagged a 0.1, which doesn't match what I pushed as 0.1 on PyPI.

jacquerie commented 8 years ago

What I did: removed the 0.1 from PyPI, pushed a convenience commit to be tagged for 0.2, pushed that to PyPI. Now all should be (finally!) correct.