inspirehep / beard

Bibliographic Entity Automatic Recognition and Disambiguation
Other
66 stars 36 forks source link

similarity: threshold transformer #92

Closed MSusik closed 8 years ago

MSusik commented 8 years ago

Signed-off-by: Mateusz Susik mateuszsusik@gmail.com

MSusik commented 8 years ago

Review from email by @natsheh

After a quick check, all seems to be fine.

Merging.

kaplun commented 8 years ago

Hi! What are you working on? What impact is it going to have on our usage at INSPIRE?

Would be great if you can explain more in the commit log what this commit is about.

MSusik commented 8 years ago

@kaplun We're adjusting one thing for our publication. Specifically, we're changing the way how the ethnicity features are used. These changes will be probably reverted, and if not, they won't have much impact at INSPIRE (we will leave them if they improve the accuracy). Anyway, I believe you won't be using ethnicity features for the disambiguation at INSPIRE, so you won't notice any difference.

Sorry for some glitches, like no commit log, but we're a but in a hurry (you know, deadlines :smile:)