search

inspirehep / beard

Bibliographic Entity Automatic Recognition and Disambiguation
Other
66 stars 36 forks source link

blocking: add function to block by signature block. #99

Closed salmanmaq closed 6 years ago

salmanmaq commented 6 years ago

Signature blocks are pre-computed in INSPIRE. Instead of running the blocking functions at runtime, we can use those pre-computed signature blocks without making too much changes in BEARD.

Signed-off-by: Salman Maqbool salman.maqbool@cern.ch

MSusik commented 6 years ago

Hi!

Thank you for your PR. When we were creating the library, the goal was to create an entity separate and independent from INSPIRE. Thus I would prefer not to add such a function to the library.

On the other hand, a similar functionality can be achieved by using a precomputed blocking https://github.com/inspirehep/beard/blob/87b37a3028825b5199616b195663fee526c26be3/beard/clustering/blocking.py#L146 . Will it work for you?

jacquerie commented 6 years ago

Thanks @MSusik ! I believe that that will be ok for us.