setup: bump inspire-dojson - Githubissues

inspirehep / hepcrawl

Scrapy project for feeds into INSPIRE-HEP

http://inspirehep.net

Other

17 stars 30 forks source link

setup: bump inspire-dojson #245

Closed michamos closed 6 years ago

michamos commented 6 years ago

Signed-off-by: Micha Moskovic michamos@gmail.com

Description

Related Issue

Motivation and Context

Checklist:

[ ] I have all the information that I need (if not, move to RFC and look for it).
[ ] I linked the related issue(s) in the corresponding commit logs.
[ ] I wrote good commit log messages.
[ ] My code follows the code style of this project.
[ ] I've added any new docs if API/utils methods were added.
[ ] I have updated the existing documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

david-caro commented 6 years ago

Iirc this is already breaking inspire, in the sense that inspire installs a version of hepcrawl that conflicts with it's requirement of dojson. The changes in the deps should have been done the other way around, first change hepcrawl to support the newer dojson, bumping the major, and then change inspire-next to bump both, dojson and hepcrawl to the major version.

In this case, I'm ok, as that moment already passed, so this is a hot patch. (also, nobody uses hepcrawl as it is, so we are not really breaking compatibility with anyone else).