search

inspirehep / inspire-docker

Dockerfiles for inspirehep/inspire-next application
GNU General Public License v2.0
4 stars 12 forks source link

python_base: add firefox for acceptance tests #32

Closed rikirenz closed 7 years ago

rikirenz commented 7 years ago

Adding firefox, in order to have a visible browser when we run acceptance tests

rikirenz commented 7 years ago

Ready for review

david-caro commented 7 years ago

Haven't actually checked if the machine-id file is correctly created and I don't find the log trace on the travis build page, looks ok, if nobody tests it and merges it before, I'll test later.

kaplun commented 7 years ago

Just looking at the code, LGTM

david-caro commented 7 years ago

It works ok for me locally