search

inspirehep / inspire-docker

Dockerfiles for inspirehep/inspire-next application
GNU General Public License v2.0
4 stars 12 forks source link

New dependencies are not saved in /pip-cache #55

Closed jacquerie closed 7 years ago

jacquerie commented 7 years ago

Since https://github.com/inspirehep/inspire-docker/pull/38 was merged, new dependencies are not added to the /pip-cache folder, which results in increased build times in inspire-next.

jacquerie commented 7 years ago

Uh, I was wrong, new builds appear to have stuff in the cache. Compare for example https://travis-ci.org/inspirehep/inspire-next/jobs/281634496#L661 with https://travis-ci.org/inspirehep/inspire-next/jobs/282038931#L676.

In fact, it looks like dependencies with constraints like < or <= were not being cached, which hints that the thing that actually fixed this issue is https://github.com/inspirehep/inspire-next/commit/a4e0d1b3aac748e57c65aa82b49e00e97d42d453#diff-2eeaed663bd0d25b7e608891384b7298 and similar commits.

I think this points at a bug/misunderstood behavior in requirements-builder, but we don't really care, just write the constraints like that and we're good.