inspirehep / inspire-dojson

INSPIRE-specific rules to transform from MARCXML to JSON and back.
GNU General Public License v3.0
3 stars 18 forks source link

dojson: more robust external_system_identifiers #32

Closed kaplun closed 7 years ago

kaplun commented 7 years ago

The current implementation of external_system_identifier has some short comings:

So e.g. in record https://inspirehep.net/record/700376 there:

<datafield tag="035" ind1=" " ind2=" ">
<subfield code="9">OSTI</subfield>
<subfield code="a">892532</subfield>
</datafield>
<datafield tag="035" ind1=" " ind2=" ">
<subfield code="9">OSTI</subfield>
<subfield code="z">897192</subfield>
</datafield>

The second OSTI is currently lost.

michamos commented 7 years ago

We discussed this recently during the content standup. We decided to preserve the hidden identifiers (having a z instead of an a), but put don't display them. So we could follow the same strategy as for texkeys: the first identifier with a given schema is displayed, the others are present but not shown.