search

inspirehep / inspire-next

The INSPIRE repo.
https://inspirehep.net
GNU General Public License v3.0
59 stars 69 forks source link

literature submission: thesis date includes time / phd lower case #2161

Closed annetteholtkamp closed 7 years ago

annetteholtkamp commented 7 years ago

When a submitter inserts a complete date year/month/day a time gets added: Thesis: phd UC, Santa Barbara (2016-09-01T00:00:00)

And the degree appears in lower case: phd

jmartinm commented 7 years ago

Thanks. Yes, these are known issues that @Glignos is taking care of.

jacquerie commented 7 years ago

Done in https://github.com/inspirehep/inspire-schemas/pull/138, but this is annoyingly blocked by #2134 (to get the new builder we have to bump the schema to the latest version).

jacquerie commented 7 years ago

We actually realized that in order to fix the second issue we need to fix DoJSON: phd is what is written in the schema, but we want to produce back PhD in MARCXML.

jacquerie commented 7 years ago

This should be fixed. @annetteholtkamp, can you confirm?

michamos commented 7 years ago

The PhD capitalization is fixed, not the timestamp one https://inspirehep.net/record/edit/?ln=en#state=edit&recid=1598894&recrev=20170511113857

jacquerie commented 7 years ago

Whoops, right, because inspirehep/inspire-schemas#138 in the end landed in schema>31. We could backport it to 31.2.0 to close this quicker...

jacquerie commented 7 years ago

We now have a schema that contains the changes in https://github.com/inspirehep/inspire-schemas/pull/124, so this should be fixed after a deploy.

jmartinm commented 7 years ago

Fixed and deployed