search

inspirehep / inspire-next

The INSPIRE repo.
https://inspirehep.net
GNU General Public License v3.0
59 stars 69 forks source link

Records harvested on legacy are still harvested on Labs #2310

Closed kaplun closed 7 years ago

kaplun commented 7 years ago

https://labs.inspirehep.net/holdingpen/629463 this has astro.CO and should have not been harvested.

cc @ksachs

jacquerie commented 7 years ago

What?

That is a math.CO paper. We're going to harvest those papers, because they are not in https://github.com/inspirehep/inspire-next/blob/9a3770ba2f64571e7d336eafddaed50ecce88cfe/inspirehep/config.py#L1374-L1386, the categories harvested on Legacy. It will (probably) then be rejected, because the conditions in #2115 will not be satisfied.

So I think that this is just a repetition of #2309, which notes that #2115 was incorrectly implemented in #2142.

ksachs commented 7 years ago

Sam means https://labs.inspirehep.net/holdingpen/629448 which is astro-ph.CO

jacquerie commented 7 years ago

Oh. Then I see why: the configuration has astro-ph.co, the record has astro-ph.CO (note the different capitalization), so the record comes through. It's an easy fix.

jacquerie commented 7 years ago

I just deployed this fix.

kaplun commented 7 years ago

Sam means https://labs.inspirehep.net/holdingpen/629448 which is astro-ph.CO

Yeah! Sorry for the wrong cut & paste!

Oh. Then I see why: the configuration has astro-ph.co, the record has astro-ph.CO (note the different capitalization), so the record comes through. It's an easy fix.

Damn! Thanks for the fix. I hope we have normalized these categories for the good!