global: don't build URLs with os.path.join - Githubissues

inspirehep / inspire-next

The INSPIRE repo.

https://inspirehep.net

GNU General Public License v3.0

59 stars 69 forks source link

global: don't build URLs with os.path.join #2314

Open jacquerie opened 7 years ago

jacquerie commented 7 years ago

For example: https://github.com/inspirehep/inspire-next/blob/5fdbd8bf4ac6bd984406719b6a3d0c91b0b4cf77/inspirehep/modules/workflows/tasks/submission.py#L249-L252

The right method to use is urljoin from six.

michamos commented 7 years ago

HEPCrawl is using https://github.com/gruns/furl for this which seems like a good tool for the job.