inspirehep / inspire-next

The INSPIRE repo.
https://inspirehep.net
GNU General Public License v3.0
59 stars 69 forks source link

Use raven.js #2382

Open jmartinm opened 7 years ago

jmartinm commented 7 years ago

https://docs.sentry.io/clients/javascript/

We need to check the specifics of using it with AngularJS (for Holding Pen) and with Angular 2+ for the editor.

jmartinm commented 7 years ago

@harunurhan You can start looking into this

harunurhan commented 7 years ago

@jmartinm for holding pen, there is simple way but it's not requirejs way.

after angular is loaded this should be executed.

<script src="/node_modules/raven-js/dist/raven.js"></script>
<script src="/node_modules/raven-js/dist/plugins/angular.js"></script>
<script>
  Raven
    .config('https://<key>@sentry.io/<project>')
    .addPlugin(Raven.Plugins.Angular)
    .install();
</script>

Although there are some examples, but none for requirejs. However if this is not good enough I can look into it.

jmartinm commented 7 years ago

Blocked by the version of our Sentry server (6.4.4)

From ravenjs:

For on-premise users:

Raven.js 3.6 requires Sentry server 8.6.0 or later
Raven.js 2.0 requires Sentry server 8.0.0 or later
jmartinm commented 7 years ago

@harunurhan can we close this?

harunurhan commented 7 years ago

Actually I haven't set it up for inspire-next yet, only for other angular projects.

jmartinm commented 7 years ago

OK, it would be nice to have in submission forms and Holding Pen at least, which are both used in production. Submission forms don't use Angular so no need to add the plugin.

harunurhan commented 7 years ago

ok I can set it up, Shouldn't be difficult unless we need to do sourcemap uploads?