inspirehep / inspire-next

The INSPIRE repo.
https://inspirehep.net
GNU General Public License v3.0
59 stars 69 forks source link

Sometimes test_submit_author doesn't pass #2518

Closed bavaria95 closed 7 years ago

bavaria95 commented 7 years ago

Expected Behavior

I expect test_submit_author to pass.

Current Behavior

Realized that when running acceptance tests inside the kubernetes cluster, sometimes it got stuck sending request like: 10.100.3.0 - - [06/Jul/2017:08:29:02 +0000] "GET /holdingpen/list/?workflow_name=Author&is-update=false&size=10&status=HALTED HTTP/1.1" 200 16775 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0"

It turned out that in this case author is created, but clean up happens before it's actually used: {"_index":"holdingpen-authors","_type":"authors","_id":"3","found":false} thus the test hangs indefinitely waiting for the record to be there.

jacquerie commented 7 years ago

Isn't this #2222 ?

On Thu, Jul 6, 2017, 18:32 Dmytro Petruk notifications@github.com wrote:

Expected Behavior

I expect test_submit_author to pass. Current Behavior

Realized that when running acceptance tests inside the kubernetes cluster, sometimes it got stuck sending request like: 10.100.3.0 - - [06/Jul/2017:08:29:02 +0000] "GET /holdingpen/list/?workflow_name=Author&is-update=false&size=10&status=HALTED HTTP/1.1" 200 16775 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0"

It turned out that in this case author is created, but clean up happens before it's actually used: {"_index":"holdingpen-authors","_type":"authors","_id":"3","found":false} thus the test hangs indefinitely waiting for the record to be there.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/inspirehep/inspire-next/issues/2518, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXRYAPSqutK1OUEleAjJroFZDESh_4Zks5sLKmrgaJpZM4OPYpq .

kaplun commented 7 years ago

This should have been fixed by #2502. @bavaria95 please reopen in case of regression.

david-caro commented 7 years ago

It's not any of those, for some reason the cleanup was being executed while the test was running, it was something strange... only seen that when running on kubernetes though.