search

inspirehep / inspire-next

The INSPIRE repo.
https://inspirehep.net
GNU General Public License v3.0
59 stars 69 forks source link

Restore ORCID implementation #2798

Open kaplun opened 6 years ago

kaplun commented 6 years ago

304cfcaead150ca5ab5e470dda5e51c3449550b8 removed the then current implementation of ORCID support. The first step to integrate ORCID into INSPIRE should be to restore that work and build/improve on it.

jacquerie commented 6 years ago

More realistically, this module has to be reimplemented from scratch, perhaps peeking at the previous implementation in some parts. Also consider that the ORCID API is going to change, and we're going to use a different library (https://github.com/inspirehep/inspire-next/issues/2611), so I'm not very optimistic on what can be saved here.

kaplun commented 6 years ago

I am not convinced about the from scratch part. It was left in a functional state but disabled by a feature flag because we were not yet ready to transition it from legacy (we still miss the opt-in/out functionality and the possibility to pick up a profile). Also, it was based on invenio-orcid which is also based on python-orcid, which was in turn based, IIRC, on the 2.0 RC version of the API, not on 1.3 one.

jacquerie commented 6 years ago

It was left in a functional state

No, the schema has changed a lot since, and yet the tests were still passing because they were mocking too aggressively too many things.

kaplun commented 6 years ago

Yes fine, so we need to adapt: https://github.com/inspirehep/inspire-next/commit/304cfcaead150ca5ab5e470dda5e51c3449550b8#diff-976c02effc41b0da5f3f9ce9afd561c6 (i.e. schema.py). Doesn't mean we need to throw away everything, and redo from scratch.