Closed kaplun closed 6 years ago
@ksachs @fschwenn you were volunteering for maintaining the authorlist tool, IIRC?
Smaller test case that still exhibits the bug:
A. J. Hawken1, B. R. Granett1, A. Iovino1, L. Guzzo1,2
1 INAF–Osservatorio Astronomico di Brera, via Brera 28, 20122 Milano, via E. Bianchi 46, 23807 Merate, Italy
2 Università degli Studi di Milano, via G. Celoria 16, 20130 Milano, Italy
Found it, it's failing on trailing whitespace in the affiliations.
BTW, it's also failing on trailing whitespace in the authors, but that's a different error:
J. Smith1
1 University of somewhere
fails with ('Could not find affiliations',)
.
first I have to see how to install a test version with not too much overhead. But yes - in principle its on my desk.
wash_lines deletes the linebreak if there is a trailing space. So you have to clean it before.
I don't know whether the pull-request / commit message is done properly. You need to update 1 line of code.
I don't know whether the pull-request / commit message is done properly.
Feel free to skip that etiquette if you're planning to commit once in a while, we can fix those for you. The most important thing I did was to add the tests that @michamos provided above, so that we're sure that your PR fixes this issue.
Expected Behavior
Authors and affiliations are well parsed and exported
Current Behavior
An error is presented to the user.
Steps to Reproduce (for bugs)
1 INAF–Osservatorio Astronomico di Brera, via Brera 28, 20122 Milano, via E. Bianchi 46, 23807 Merate, Italy 2 Università degli Studi di Milano, via G. Celoria 16, 20130 Milano, Italy 3 INAF – Istituto di Astrofisica Spaziale e Fisica Cosmica Milano, via Bassini 15, 20133 Milano, Italy 4 Aix-Marseille Université, CNRS, LAM (Laboratoire d’Astrophysique de Marseille) UMR 7326, 13388 Marseille, France 5 INAF–Osservatorio Astronomico di Torino, 10025 Pino Torinese, Italy 6 Canada-France-Hawaii Telescope, 65–1238 Mamalahoa Highway, Kamuela, HI 96743, USA 7 Aix-Marseille Université, CNRS, CPT, UMR 7332, 13288 Marseille, France 8 INAF–Osservatorio Astronomico di Bologna, via Ranzani 1, 40127 Bologna, Italy 9 Dipartimento di Matematica e Fisica, Università degli Studi Roma Tre, via della Vasca Navale 84, 00146 Roma, Italy 10 Institute of Cosmology and Gravitation, Dennis Sciama Building, University of Portsmouth, Burnaby Road, Portsmouth, PO1 3FX, UK 11 INAF–Osservatorio Astronomico di Trieste, via G. B. Tiepolo 11, 34143 Trieste, Italy 12 Institute for Astronomy, University of Edinburgh, Royal Observatory, Blackford Hill, Edinburgh EH9 3HJ, UK 13 Institute of Physics, Jan Kochanowski University, ul. Swietokrzyska 15, 25-406 Kielce, Poland 14 Department of Particle and Astrophysical Science, Nagoya University, Furo-cho, Chikusa-ku, 464-8602 Nagoya, Japan 15 Dipartimento di Fisica e Astronomia, Alma Mater Studiorum Università di Bologna, viale Berti Pichat 6/2, 40127 Bologna, Italy 16 INFN, Sezione di Bologna, viale Berti Pichat 6/2, 40127 Bologna, Italy 17 Laboratoire Lagrange, UMR 7293, Université de Nice Sophia Antipolis, CNRS, Observatoire de la Côte d’Azur, 06300 Nice, France 18 Astronomical Observatory of the Jagiellonian University, Orla 171, 30-001 Cracow, Poland 19 National Centre for Nuclear Research, ul. Hoza 69, 00-681 Warszawa, Poland 20 INAF–Istituto di Astrofisica Spaziale e Fisica Cosmica Bologna, via Gobetti 101, 40129 Bologna, Italy 21 INAF–Istituto di Radioastronomia, via Gobetti 101, 40129 Bologna, Italy 22 INFN, Sezione di Roma Tre, via della Vasca Navale 84, 00146 Roma, Italy 23 INAF–Osservatorio Astronomico di Roma, via Frascati 33, 00040 Monte Porzio Catone (RM), Italy
(the error was retrieved via IPython)
@mathieugrives