Holding pen: action buttons and status banner misleading

[ksachs]

Expected Behavior

If a new workflow matches another in the holdingpen only one of them should be active.

Current Behavior

If the old WF is waiting due to

• 'Resolve Conflicts'
• 'Matching' (might be fixed, but with wrong status message of the stopped WF)

all matching WFs are active. AFAIK only 'CORE selection' stops the old WF.

Examples:

https://labs.inspirehep.net/holdingpen/1418124 https://labs.inspirehep.net/holdingpen/1416234

https://labs.inspirehep.net/holdingpen/1416009 https://labs.inspirehep.net/holdingpen/1413901

For 1901.07401 one WF is completed, 4 others are active, no record in labs or legacy. https://labs.inspirehep.net/holdingpen/1414875 claims 'Ingestion complete',

In fact it was stopped by another WF:

doc "Halt the workflow object, action=match_approval, message=Halted for matching approval."
time    "2019-01-23 12:23:54.214843"

doc "Mark the workflow object with stopped-by-wf:1415831."
time    "2019-01-24 07:10:57.504640"

Screenshots (if appropriate):

[michamos]

I'm not sure I understand what you're saying. The previous ones are stopped because a new one came in, which is waiting due to merge conflicts: https://labs.inspirehep.net/holdingpen/1419777. The buttons on the list view are misleading, they always show if there are merge conflicts, even if the workflow is completed.

[ksachs]

I didn't check the fine print. Whatever has an action-button looks active to me. And I usually work from list view.

I think stopped WFs should not have action buttons. Well - if I'm aware of it, I can select 'Awaiting decision', so it's not super urgent to change.

'Ingestion complete' should mean the record is in INSPIRE. Or this should be renamed to 'Workflow complete'. Whatever you want, but it should mean what it is saying.