search

inspirehep / invenio-grobid

Invenio package for integration of the Grobid metadata extraction service
GNU General Public License v2.0
4 stars 3 forks source link

Split utils in extras and mapping, and test the latter #13

Closed jacquerie closed 8 years ago

jacquerie commented 8 years ago

You might ask: why is the dictionary included in the code, instead of being pickled and retrieved as a fixture?

The idea is that a change in the logic in mapping.py will correspond to a change inside of the dictionary. In this way, the change can be inspected in the PR, instead of being inside an opaque binary object.

jacquerie commented 8 years ago

Also: this ups the coverage to a respectable 92%. I think it's time to release on PyPI!

jalavik commented 8 years ago

Excellent :+1: I will prepare a release this week.