search

inspirehep / plotextractor

Extract images and captions from TeX files in a tar archive.
GNU General Public License v2.0
3 stars 9 forks source link

untar set mtimes to now #14

Closed tsgit closed 7 years ago

tsgit commented 7 years ago

as far as I can tell inspire-next/inspirehep/modules/workflows/tasks/arxiv.py uses from plotextractor.converter import untar

and untar preserves the mtimes in the tar file. This leads to premature garbage collection on "old" files.

This patch changes the mtime of all members of the tar file to int(time.time()) which is seconds since epoch for now

Signed-off-by: Thorsten Schwander thorsten.schwander@gmail.com

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 74.899% when pulling f8c8d87345d5953e3f7212ad2f927be21ff73f5a on tsgit:untar-mtimes into 2bd31483298083ec0c37c461e10bece533fec483 on inspirehep:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 74.933% when pulling 91bea60b6fa0d64159fff10451c1c953e1448284 on tsgit:untar-mtimes into 2bd31483298083ec0c37c461e10bece533fec483 on inspirehep:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 74.933% when pulling 91bea60b6fa0d64159fff10451c1c953e1448284 on tsgit:untar-mtimes into 2bd31483298083ec0c37c461e10bece533fec483 on inspirehep:master.

kaplun commented 7 years ago

LGTM!