search

inspirehep / plotextractor

Extract images and captions from TeX files in a tar archive.
GNU General Public License v2.0
3 stars 9 forks source link

prepare_image_data: handle also relative paths #25

Closed david-caro closed 6 years ago

david-caro commented 6 years ago

Signed-off-by: David Caro david@dcaro.es

david-caro commented 6 years ago

Related sentry issue: https://sentry.inspirehep.net/inspire-sentry/prod/issues/693/

michamos commented 6 years ago

I guess this closes #16 and #23?

david-caro commented 6 years ago

Not completely sure about #16, but #23 yep

michamos commented 6 years ago 
In [7]: os.path.abspath('foo//bar')
Out[7]: '/home/micha/src/inspire-schemas/foo/bar'
david-caro commented 6 years ago

As @tsgit suggests, normpath is better there :)

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.03%) to 75.034% when pulling 1d67223c1a02adfe41a59e0f1fc2cf268a85d627 on david-caro:handle_rel_paths into 8671ddc54c4dc9bbbd30bc32cadee16256622987 on inspirehep:master.