inspirehep / record-editor

Record editing tool used in http://inspirehep.net
GNU General Public License v2.0
6 stars 16 forks source link

Improve messages in custom validators #231

Open jmartinm opened 6 years ago

jmartinm commented 6 years ago

Custom validators are defined https://github.com/inspirehep/record-editor/blob/master/src/app/shared/services/app-config.service.ts#L510-L512

If, for example a date is wrong, the message: "Should match format 'date'" is displayed, which is not useful to know which formats are allowed.

An improvement would be to able to customize these messages.

harunurhan commented 6 years ago

Blocked by this https://github.com/inveniosoftware-contrib/ng2-json-editor/issues/417

harunurhan commented 6 years ago

this is was unblocked while ago, I just realized. If you post list of validations error messages to configure and what to put instead of the default one, I'll add them to configurations. @jmartinm @StellaCh