kb-handling: Refactor kb files management

inspirehep / refextract

Extract bibliographic references from (High-Energy Physics) articles.

GNU General Public License v2.0

130 stars 30 forks source link

kb-handling: Refactor kb files management #27

Closed zzacharo closed 7 years ago

zzacharo commented 7 years ago

Unifies kb file handling for all kb builders

Signed-off-by: Zacharias Zacharodimos zacharias.zacharodimos@cern.ch

coveralls commented 7 years ago

Coverage decreased (-12.01%) to 66.324% when pulling 8c4939e200bb6b87305d1cb43ecc00fda493471d on zzacharo:refactor-file-handling into 27588da5611f34266fd54fdbf8784814fffa0e7b on inspirehep:master.

zzacharo commented 7 years ago

@kaplun @jacquerie I did some refactoring to kbs file handling! Check it please.

coveralls commented 7 years ago

Coverage increased (+0.7%) to 79.076% when pulling 8c59f61554ae8697bc647d7e7483aaea90e55a42 on zzacharo:refactor-file-handling into 27588da5611f34266fd54fdbf8784814fffa0e7b on inspirehep:master.

zzacharo commented 7 years ago

@kaplun done!

kaplun commented 7 years ago

Looks like Travis is bad on Python 2.6, but since we don't intend to support Python 2.6 anymore (only legacy is on 2.6), can you add a commit where you drop Python 2.6 from the Travis build matrix and setup.py (if it's there)?

zzacharo commented 7 years ago

@kaplun done!

coveralls commented 7 years ago

Coverage increased (+0.7%) to 79.076% when pulling e1dc83392e37698f206d27144eb57db9a04dd65c on zzacharo:refactor-file-handling into 27588da5611f34266fd54fdbf8784814fffa0e7b on inspirehep:master.

kaplun commented 7 years ago

Yep, can you also amend indeed: https://github.com/inspirehep/refextract/blob/master/setup.py#L121 (just leave the 2.7 line, because since we are not currently testing on 3.x we can't guarantee it's actually supported).

zzacharo commented 7 years ago

@jacquerie @kaplun have a look again. I deleted all the print functions for now as they weren't make sense because exceptions are implying that our code is wrong so we must get the exception and fix the root problem. If a logger is needed in the future we can add it in another PR.

coveralls commented 7 years ago

Coverage increased (+0.7%) to 79.013% when pulling 613fb28509cf457c4499f0294b05832d84b2265d on zzacharo:refactor-file-handling into 27588da5611f34266fd54fdbf8784814fffa0e7b on inspirehep:master.

zzacharo commented 7 years ago

@kaplun done!