Closed nayeonshin closed 2 years ago
@funbeedev Hey! Could you please take a look into this PR? I'm not sure why some checks are failing.
@nayeonshin Could you please update your PR so only tuples-basic.py
is the only file submitted and delete the other files? I've marked this PR as hacktoberfest accepted so it counts in time for hacktoberfest but make the changes needed so we can merge into the repo. Thanks!
@funbeedev Yes, of course! TYSM :) Doing this rn
Hmm... this is weird. I might have messed something up in run-modified-python.sh
. Don't recall if I directly changed this when working in this PR for the first time. I just tried manually fixing it (by putting the same thing from the upstream's main branch), but it doesn't seem to be successful. Sorry about the hassle! 😔 Should I just close this PR and create another one with tuples-basic.py
only? I probably shouldn't have used an IntelliJ IDE that automatically creates and puts an unnecessary .idea
in the main directory. (I was filtering this out with .gitignore
.)
@nayeonshin hmm not sure why that's happening. Are you able to revert the changes to run-modified-python.sh
file on your git repo locally? If that doesn't work you can raise another PR
@funbeedev Thanks for your reply! I succeeded in reverting that file but the execute-modified-python-file
still fails 🤯:
Run echo "job: running script to execute modified file:"
job: running script to execute modified file:
run-sh: Inside run-modified-python.sh
run-sh: Content of files_modified.json: [
".github/workflows/run-modified-python.sh",
"tuples/tuples-basic.py"
]
run-sh: After parsing, file to execute:
.github/workflows/run-modified-python.sh
tuples/tuples-basic.py
run-sh: This is a .py file, executing
File ".github/workflows/run-modified-python.sh", line 3
echo "run-sh: Inside run-modified-python.sh"
^
SyntaxError: invalid syntax
Error: Process completed with exit code 1.
@funbeedev Hey there! Could you please help me resolve this? TY in advance :)
@nayeonshin Sorry for the delay in checking this and thanks for the reminder! I can't see why the check is failing and it appears to be an issue with the workflow run. I'll merge your PR and sort out the workflow issue separately. Thanks for your contribution! :smile: :tada:
1. This pull request resolves #91
2. Description
tuples
dir andtuples-basic.py
undertuples
3. Fill in checklist by marking [x]
Apologies for my late submission! I didn't want to touch the README, so I guess it should be updated after this PR gets merged.