instacart / Snacks

The Instacart Component Library
https://instacart.github.io/Snacks/
Apache License 2.0
81 stars 36 forks source link

Use process.env.NODE_ENV for dev warning #342

Closed nathanmarks closed 5 years ago

nathanmarks commented 5 years ago

This caused problems for the ESM build unless the ___DEV___ global is defined.... as you can imagine

codecov[bot] commented 5 years ago

Codecov Report

Merging #342 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files          59       59           
  Lines        1221     1221           
  Branches      218      218           
=======================================
  Hits         1004     1004           
  Misses        165      165           
  Partials       52       52