instacart / Snacks

The Instacart Component Library
https://instacart.github.io/Snacks/
Apache License 2.0
81 stars 36 forks source link

Add SVG component type declaration generation and verification #344

Closed nathanmarks closed 5 years ago

nathanmarks commented 5 years ago

The generated SVG components weren't getting declarations generated. Didn't see this in a consuming project initially as the TS compiler allowed the global declaration for .svg modules in said project to apply to the imports ending in .svg.

This now generates declarations for those files.

I've also added two additional steps to the build verification process:

codecov[bot] commented 5 years ago

Codecov Report

Merging #344 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files          59       59           
  Lines        1221     1221           
  Branches      218      218           
=======================================
  Hits         1004     1004           
  Misses        165      165           
  Partials       52       52