instacart / Snacks

The Instacart Component Library

https://instacart.github.io/Snacks/

Apache License 2.0

81 stars 36 forks source link

Add labelElementType prop to NavigationPills component to allow customization of tagName for component's label #433

Closed glenndixon closed 4 years ago

glenndixon commented 4 years ago

https://instacart.atlassian.net/browse/CS-22918

Re: the coveralls removal, I got direction from @nathanmarks to remove it on Slack.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3ba10e4). Click here to learn what that means. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #433   +/-   ##
=========================================
  Coverage          ?   83.85%           
=========================================
  Files             ?       62           
  Lines             ?     1301           
  Branches          ?      230           
=========================================
  Hits              ?     1091           
  Misses            ?      159           
  Partials          ?       51