feat: add props id, aria-selected, aria-disabled, and aria-label to button component - Githubissues

instacart / Snacks

The Instacart Component Library

https://instacart.github.io/Snacks/

Apache License 2.0

81 stars 36 forks source link

feat: add props id, aria-selected, aria-disabled, and aria-label to button component #445

Closed dfadler1984 closed 4 years ago

dfadler1984 commented 4 years ago

I'm working on https://instacart.atlassian.net/browse/CS-26787 which will require me to add an id and a number of aria props to the button in https://github.com/instacart/carrot/blob/master/customers/instacart/app/assets/javascripts/store_app/components/shared/ServiceTypeControl/index.jsx#L26

dfadler1984 commented 4 years ago

Closing in favor of using elementAttributes