instacart / formula

A functional reactive framework for managing state and side effects based on RxJava.
https://instacart.github.io/formula/
BSD 3-Clause Clear License
151 stars 14 forks source link

Reorder FlowAction.fromFlow params #372

Closed Jawnnypoo closed 3 months ago

Jawnnypoo commented 3 months ago

If we are moving from RxAction to FlowAction and including a key, you can see the difference between the params on both.

val key = "123"
RxAction.fromObservable(key) {
...
}

If we do a direct change over to FlowAction:

val key = "123"
FlowAction.fromFlow(key) {
...
}

^ this throws an exception because it is expecting you to pass a scope. We can reorder the params to where the key is first, to keep it consistent with RxAction 👍

carrotkite commented 3 months ago
1 Warning
:warning: No coverage data found for com/instacart/formula/coroutines/FlowAction

JaCoCo Code Coverage 83.92% :white_check_mark:

Class Covered Meta Status
com/instacart/formula/coroutines/FlowAction No coverage data found : -% No coverage data found : -% :black_joker:

Generated by :no_entry_sign: Danger

Jawnnypoo commented 3 months ago

Closing in favor of https://github.com/instacart/formula/pull/373