instacart / makara

A Read-Write Proxy for Connections; Also provides an ActiveRecord adapter.
http://tech.taskrabbit.com/
MIT License
928 stars 170 forks source link

Update rubocop requirement from ~> 1.9.1 to ~> 1.12.1 #306

Closed dependabot[bot] closed 3 years ago

dependabot[bot] commented 3 years ago

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.12.1

Bug fixes

  • #9649: Fix when highlights contain multibyte characters. (@​osyo-manga)
  • #9646: Fix an incorrect auto-correct for EnforcedStyle: require_parentheses of Style/MethodCallWithArgsParentheses with EnforcedStyle: conditionals of Style/AndOr. (@​koic)
  • #9608: Fix a false positive for Layout/EmptyLineAfterGuardClause when using guard clause is after rubocop:enable comment. (@​koic)
  • #9637: Allow parentheses for forwarded args in Style/MethodCallWithArgsParentheses's omit_parentheses style to avoid endless range ambiguity. (@​gsamokovarov)
  • #9641: Fix Layout/MultilineMethodCallIndentation triggering on method calls that look like operators. (@​dvandersluis)
  • #9638: Fix an error for Layout/LineLength when over limit at right hand side of multiple assignment. (@​koic)
  • #9639: Fix Style/RedundantBegin removing comments on assignment statement correction. (@​marcotc)
  • #9671: Fix an incorrect auto-correct for Lint/AmbiguousOperator with Style/MethodCallWithArgsParentheses. (@​koic)
  • #9645: Fix an incorrect auto-correct for Style/SingleLineMethods when using single line class method definition. (@​koic)
  • #9644: Fix an error and an incorrect auto-correct for Style/MultilineMethodSignature when line break after opening parenthesis. (@​koic)
  • #9672: Fix an incorrect auto-correct for Style/HashConversion when using multi-argument Hash[] as a method argument. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.12.1 (2021-04-04)

Bug fixes

  • #9649: Fix when highlights contain multibyte characters. ([@​osyo-manga][])
  • #9646: Fix an incorrect auto-correct for EnforcedStyle: require_parentheses of Style/MethodCallWithArgsParentheses with EnforcedStyle: conditionals of Style/AndOr. ([@​koic][])
  • #9608: Fix a false positive for Layout/EmptyLineAfterGuardClause when using guard clause is after rubocop:enable comment. ([@​koic][])
  • #9637: Allow parentheses for forwarded args in Style/MethodCallWithArgsParentheses's omit_parentheses style to avoid endless range ambiguity. ([@​gsamokovarov][])
  • #9641: Fix Layout/MultilineMethodCallIndentation triggering on method calls that look like operators. ([@​dvandersluis][])
  • #9638: Fix an error for Layout/LineLength when over limit at right hand side of multiple assignment. ([@​koic][])
  • #9639: Fix Style/RedundantBegin removing comments on assignment statement correction. ([@​marcotc][])
  • #9671: Fix an incorrect auto-correct for Lint/AmbiguousOperator with Style/MethodCallWithArgsParentheses. ([@​koic][])
  • #9645: Fix an incorrect auto-correct for Style/SingleLineMethods when using single line class method definition. ([@​koic][])
  • #9644: Fix an error and an incorrect auto-correct for Style/MultilineMethodSignature when line break after opening parenthesis. ([@​koic][])
  • #9672: Fix an incorrect auto-correct for Style/HashConversion when using multi-argument Hash[] as a method argument. ([@​koic][])

1.12.0 (2021-03-24)

New features

  • #9615: Add new Style/StringChars cop. ([@​koic][])
  • #9629: Add AllowParenthesesInStringInterpolation configuration to Style/MethodCallWithArgsParentheses to allow parenthesized calls in string interpolation. ([@​gsamokovarov][])
  • #9219: Allow excluding some constants from Style/Documentation. ([@​fsateler][])
  • Add AllowNil option for Lint/SuppressedException to allow/disallow rescue nil. ([@​corroded][])

Bug fixes

  • #9560: Fix an error for Lint/ClassMethodsDefinitions when defining class methods with class << self with comment only body. ([@​koic][])
  • #9551: Fix a false positive for Style/UnlessLogicalOperators when using || operator and invoked method name includes "or" in the conditional branch. ([@​koic][])
  • #9620: Allow parentheses in operator methods calls for Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses. ([@​gsamokovarov][])
  • #9622: Fixed Style/BisectedAttrAccessor autocorrection to handle multiple bisected attrs in the same macro. ([@​dvandersluis][])
  • #9606: Fix an error for Layout/IndentationConsistency when using access modifier at the top level. ([@​koic][])
  • #9619: Fix infinite loop between Layout/IndentationWidth and Layout/RescueEnsureAlignment autocorrection. ([@​dvandersluis][])
  • #9633: Fix an incorrect auto-correct for Lint/NumberConversion when to_i method in symbol form. ([@​koic][])
  • #9616: Fix an incorrect auto-correct for Style/EvalWithLocation when using #instance_eval with a string argument in parentheses. ([@​koic][])
  • #9429: Fix Style/NegatedIfElseCondition autocorrect to keep comments in correct branch. ([@​tejasbubane][])
  • #9631: Fix an incorrect auto-correct for Style/RedundantReturn when using return with splat argument. ([@​koic][])
  • #9627: Fix an incorrect auto-correct for Style/StructInheritance when extending instance of Struct without do ... end and class body is empty. ([@​koic][])
  • #5953: Fix a false positive for Style/AccessModifierDeclarations when using module_function with symbol. ([@​koic][])
  • #9593: Fix an error when processing a directory is named {}. ([@​koic][])
  • #9599: Fix an error for Style/CaseLikeIf when using include? without a receiver. ([@​koic][])
  • #9582: Fix incorrect auto-correct for Style/ClassEqualityComparison when comparing Module#name for equality. ([@​koic][])
  • #9603: Fix a false positive for Style/SoleNestedConditional when using nested modifier on value assigned in condition. ([@​koic][])
  • #9598: Fix RuboCop::MagicComment#valid_shareable_constant_value?. ([@​kachick][])
  • #9625: Allow parentheses in yield arguments with Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses to fix invalid Ruby auto-correction. ([@​gsamokovarov][])
  • #9558: Fix inconsistency when dealing with URIs that are wrapped in single quotes vs double quotes. ([@​dvandersluis][])
  • #9613: Fix a false positive for Style/RedundantSelf when a self receiver on an lvalue of mlhs arguments. ([@​koic][])
  • #9586: Update Naming/RescuedExceptionsVariableName to not register on inner rescues when nested. ([@​dvandersluis][])

Changes

... (truncated)

Commits
  • adf5629 Cut 1.12.1
  • a5c2887 Update Changelog
  • 7f45422 Document that we allow parens where omitting them is ambiguous or invalid
  • 93ecd7e Parenthesized forwarded args in Style/MethodCallWithArgsParentheses
  • c8c3358 Configure rspec shared_context_metadata_behavior to :apply_to_host_groups (co...
  • 50dc01e [Fix #9672] Fix an incorrect auto-correct for Style/HashConversion
  • f4e72bc Merge pull request #9671 from koic/fix_incorrect_autocorrect_for_ambiguous_op...
  • e0342b2 Fix an incorrect auto-correct for Lint/AmbiguousOperator
  • 1cd90c7 Remove (almost) redundant setting.
  • 2d1fd7b Merge pull request #9646 from koic/fix_incorrect_autocorrect_for_style_and_or
  • Additional commits viewable in compare view


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
dependabot[bot] commented 3 years ago

Superseded by #309.