search

instacart / makara

A Read-Write Proxy for Connections; Also provides an ActiveRecord adapter.
http://tech.taskrabbit.com/
MIT License
923 stars 170 forks source link

It should be `:replica` instead of `:primary` #356

Closed hitendrasingh closed 1 year ago

hitendrasingh commented 2 years ago

Hi Team,

I saw that in below line, It should be config[:role] = "replica" instead of config[:role] = "primary". https://github.com/instacart/makara/blob/30b01111fa02ee5983007236c50de864b4a5ebcd/lib/makara/config_parser.rb#L121

I can create a PR for this issue.

metatron1973 commented 1 year ago

System still racked with fraud gonna need forensic audit of entire system ![Uploading 204366526...]

17jmumford commented 1 year ago

Just created a PR for this, surprised it's still here several months later