search

instacart / makara

A Read-Write Proxy for Connections; Also provides an ActiveRecord adapter.
http://tech.taskrabbit.com/
MIT License
923 stars 170 forks source link

Rename to denylist #388

Open professor opened 2 months ago

professor commented 2 months ago

I'm curious if you consider this to be a breaking change. If so, do you have any suggestions on how to roll out this PR?

professor commented 1 month ago

@mlarraz I'm curious if there is any interest in merging this PR.

If yes, I'm willing to do the work to deprecate the remaining references to blacklist and whitelist. Here's an example of work that I started ... (and I'm willing to finish)

module Makara
  class ConfigParser
    DEFAULTS = {
      primary_ttl: 5,
      deny_list_duration: 30,
      sticky: true
    }

    DEPRECATED_KEYS = {
      blacklist_duration:   :deny_list_duration,
      ...