adding android sdk 31 support

cp-yfukuda commented 3 years ago

for supporting android sdk 31, manifest merge will fail there is no explicit export attribute is not set. ---- Error ----- Manifest merger failed : android:exported needs to be explicitly specified for . Apps targeting Android 12 and higher are required to specify an explicit value for android:exported when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.

pablogeek commented 3 years ago

@kaushikgopal Can this be merged please? We need this in order to compile it for android 12

ribafish commented 3 years ago

Note, this is a duplicate of https://github.com/instacart/truetime-android/pull/136, but yes, @kaushikgopal or anyone else, can we please merge either of these two as it is blocking app updates to api 31 (which is now stable).

kaushikgopal commented 3 years ago

I’ll get to this by EOD today. 🙏🏽 thanks for the ping + callout.

On Wed, Oct 6, 2021 at 7:42 AM Gašper Kojek @.***> wrote:

Note, this is a duplicate of #136 https://github.com/instacart/truetime-android/pull/136, but yes, @kaushikgopal https://github.com/kaushikgopal or anyone else, can we please merge either of these two as it's blocking app updated to api 31 (which is now stable).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/instacart/truetime-android/pull/140#issuecomment-936389983, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH6M5OM4ON7AJ74PWHHSQLUFRN5DANCNFSM5EFF4POA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

kaushikgopal commented 3 years ago

I've merged https://github.com/instacart/truetime-android/pull/136; I think exported=false fits better as we most likely want this receiver to be launched only by components of the same application.

🙏thanks for the gentle nudge on this @pablogeek + @ribafish + @cp-yfukuda

cp-yfukuda commented 3 years ago

Hi @kaushikgopal , do you know when this will be published through gitpack?

Thank you!

pablogeek commented 3 years ago

Wondering the same here!

kaushikgopal commented 3 years ago

ah, I should have mentioned this. so this is "automatically" available through jitpack with the following url:

    dependencies {
            implementation 'com.github.instacart:truetime-android:ddde9c4b66'
    }

If some folks here can confirm that that works, I can then officially tag an incremental version and it should be available.

I'll probably bump it to a 3.5 once we get the 🏁

kaushikgopal commented 3 years ago

let's move discussions to https://github.com/instacart/truetime-android/pull/136#issuecomment-946168707

instacart / truetime-android

adding android sdk 31 support #140