instaclick / php-webdriver

W3C and Selenium 2 webdriver "thin client" for php 5.3+ and namespaces.
Other
436 stars 62 forks source link

Auto init curlService on WebDriver Abstract. #106

Closed vibbow closed 3 years ago

vibbow commented 4 years ago

curlService in AbstractWebDriver should not be set manually on every instance been create (WebDriver, Session, Element), Instead, it should be automatic initialized by get from ServiceFactory.

If user want a different curlService, they should implement WebDriver\Service\CurlServiceInterface and set the global default curlService by ServiceFactory::getInstance()->setService('service.curl', $curlService);