search

instaclick / php-webdriver

W3C and Selenium 2 webdriver "thin client" for php 5.3+ and namespaces.
Other
435 stars 62 forks source link

Fix Session::{execute, execute_async}, must use value result #111

Closed mvorisek closed 2 years ago

mvorisek commented 2 years ago

Fix release, https://github.com/instaclick/php-webdriver/commit/8bb204d82c323fe1ccd308861045422eaa315a07 refactoring has broken the Session::{execute, execute_async} methods.

parent::execute($jsonScript) is equivalent to: $this->curl('POST', '/execute', $jsonScript)['value']
not
$this->curl('POST', '/execute', $jsonScript)

tested /w https://github.com/instaclick/php-webdriver/pull/110#issuecomment-1099634396 example, ideally such example should be added to tests

robocoder commented 2 years ago

Thanks again.