instaclick / php-webdriver

W3C and Selenium 2 webdriver "thin client" for php 5.3+ and namespaces.
Other
436 stars 62 forks source link

Fix execute serialization compatibility with Selenium 2.x #113

Closed mvorisek closed 2 years ago

mvorisek commented 2 years ago

https://github.com/instaclick/php-webdriver/pull/110 support is not working with Selenium 2.x as it does support only the legacy key.

Selenium 3.x is supporting both exclusively but also both together. Although Selenium 2.x does not support the W3C key, it does still acept both together.

I have no environment with the new Selenium 4.x by hand, but Selenium 2.x and 3.x accept the serialized element even when there is any other key present, thus I am quite confident Selenium 4.x will support also this compatibility solution with both keys passed.

This is a bugfix, please tag a new release once merged.

robocoder commented 2 years ago

Tagged. Thanks again!