instaclick / php-webdriver

W3C and Selenium 2 webdriver "thin client" for php 5.3+ and namespaces.
Other
436 stars 62 forks source link

Remove the moveto command #120

Closed justafish closed 1 year ago

justafish commented 1 year ago

118 doesn't seem to be fixed - as the command is still listed an UnknownCommand exception is never raised.

For example this call in MinkSelenium2Driver will cause something like the following error:

WebDriver\Exception\ScriptTimeout: Unable to execute request for an existing session: POST /session/1ddbbcdee7165bfc65954ed44175b1f1/moveto
[test:phpunit:functional] Build info: version: '4.3.0', revision: 'a4995e2c09*'
[test:phpunit:functional] System info: host: 'f998d40750df', ip: '172.21.0.5', os.name: 'Linux', os.arch: 'amd64', os.version: '5.14.0-1054-oem', java.version: '11.0.15'
[test:phpunit:functional] Driver info: driver.version: unknown
[test:phpunit:functional] 
[test:phpunit:functional] /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:198
[test:phpunit:functional] /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:174
[test:phpunit:functional] /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:234
[test:phpunit:functional] /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Container.php:241
[test:phpunit:functional] /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:799
[test:phpunit:functional] /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:791
[test:phpunit:functional] /var/www/html/vendor/behat/mink/src/Element/NodeElement.php:153
[test:phpunit:functional] /var/www/html/vendor/behat/mink/src/Element/NodeElement.php:161
[test:phpunit:functional] /var/www/html/web/core/tests/Drupal/Tests/UiHelperTrait.php:100
[test:phpunit:functional] /var/www/html/web/core/tests/Drupal/Tests/UiHelperTrait.php:257
[test:phpunit:functional] /var/www/html/web/modules/custom/testmodule/tests/src/ExistingSiteJavascript/ExampleSelenium2DriverTest.php:25
[test:phpunit:functional] /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
[test:phpunit:functional] /var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:673
[test:phpunit:functional] /var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:673
[test:phpunit:functional] /var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:673
[test:phpunit:functional] /var/www/html/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:661
[test:phpunit:functional] /var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:144
[test:phpunit:functional] /var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:97
justafish commented 1 year ago

@robocoder :wave: Is there any chance you could review this please? I can't upgrade any selenium images beyond 4.1.2 due to this bug

robocoder commented 1 year ago

118 re-opened for further investigation but closing this PR cuz this isn't the fix.