fix: catch ScriptTimeout exception into a variable

instaclick / php-webdriver

W3C and Selenium 2 webdriver "thin client" for php 5.3+ and namespaces.

Other

436 stars 62 forks source link

Closed phil-davis closed 9 months ago

phil-davis commented 9 months ago

Fixes #127

My Behat UI tests pass with these changes. See the issue for details of the problem.

My IDE also notices the problem and tells me: Catching exceptions without capturing them to variables is only possible since PHP 8.0

So the code released in 1.4.17 will work on PHP 8 but not on PHP 7. I am running tests with PHP 7.4

phil-davis commented 9 months ago

@robocoder any chance to get this merged and a 1.4.18 patch released?