search

instaclick / php-webdriver

W3C and Selenium 2 webdriver "thin client" for php 5.3+ and namespaces.
Other
436 stars 62 forks source link

Add proxy support #93

Closed dorianboulch closed 5 years ago

dorianboulch commented 5 years ago

As Curl CLI supports http proxy via environment variable, we should add a curl opt when this variable is present. This could be improved by adding authentication support later.

dorianboulch commented 5 years ago

In deed, maybe this is not the best way to do it but I think it would be very useful to have this feature. Do you have an idea about how implement it differently ?

robocoder commented 5 years ago

@dorianboulch It's been a while since I've looked at proxy support (discussed in #53 and #73, in part). You could take a look at https://gist.github.com/markpol/d92918d21612f56a6548

dorianboulch commented 5 years ago

@robocoder your solution seems to work but don't you think it should be a built-in feature ?

robocoder commented 5 years ago

I don't think it requires specific knowledge about proxy settings. This is handled generically by $extraOptions.