instadeepai / Mava

🦁 A research-friendly codebase for fast experimentation of multi-agent reinforcement learning in JAX
Apache License 2.0
709 stars 83 forks source link

[FEATURE] Move pre-commit hooks to ruff #1002

Closed callumtilbury closed 2 months ago

callumtilbury commented 8 months ago

Feature

There have been many discussions to move our python tooling to ruff, as seen in many popular libraries in the community. This will be a big once-off effort, but will make our pre-commit hooks much faster.

Proposal

Once-off big push to use ruff's tooling. Will need to match current settings to those in ruff in the best way possible.

Testing

Tested by inspection, to see if we're happy with the formatting styles from ruff.

Benchmarking (Optional)

n/a

Definition of done

When ruff is used for our pre-commit hooks in Mava.

Mandatory checklist before making a PR

Links / references / screenshots

https://github.com/astral-sh/ruff