search

instadeepai / Mava

🦁 A research-friendly codebase for fast experimentation of multi-agent reinforcement learning in JAX
Apache License 2.0
709 stars 83 forks source link

[BUG]: Flasbax bug on LBF (type issue) #1032

Closed lbeyers closed 7 months ago

lbeyers commented 7 months ago

Describe the bug

In the AgentID wrapper, the new_agents_view type is not enforced to be consistent, so for LBF with flashbax a dtype error emerges.

To Reproduce

Steps to reproduce the behavior:

  1. Run LBF with flashbax.

Expected behavior

Expected the observation to be added easily to the buffer.

Context (Environment)

Additional context

This is somewhat an exercise in opening an issue!

Possible Solution

Will make a PR soon! Basically a cast to the agents_view type.

WiemKhlifi commented 7 months ago

Thank you @lbeyers for catching this! A question here, did you test this with Rware? And can you please test this with Matrax as well 🙏

Extra: This commit would help for understanding the issue at the moment 😄