Enhancement: change config to `DictConfig` instead of `Dict`

instadeepai / Mava

🦁 A research-friendly codebase for fast experimentation of multi-agent reinforcement learning in JAX

Apache License 2.0

709 stars 83 forks source link

Enhancement: change config to `DictConfig` instead of `Dict` #973

Closed OmaymaMahjoub closed 8 months ago

OmaymaMahjoub commented 9 months ago

What?

Implement config that supports Hydra syntax.

Why?

To simplify code and improve readability, replacing cumbersome dictionary-based config access in Mava systems with Hydra's default syntax.

How?

Change configuration references from config["key"]["subkey"] to config.key.subkey, enhancing code clarity and maintainability.## Extra This PR is based on #972 , therefore to review this PR we need to review #972 first! Close #949

OmaymaMahjoub commented 8 months ago

Thank Omayma for these changes, it's better than the old version 🙏 Are we going to update the ff_ippo_store_experience.py file?

Yeah, you are right we need to change it as we changed the logger and evaluator to only accept dictconfig, I will make the necessary changes soon :pray: