This is quite confusing so please check this carefully and make sure I haven't mixed up where to use each one!
What?
Mostly explained in #951. We are mixing up termination and truncation. This is especially prevalent in recurrent systems, but all systems have this issue.
Now very explicit about termination vs truncation, removed all mentions of done.
Done attribute remove from RnnLearnerState and replaced with truncated in the PpoTransition.
How?
Explicitly name variables termination and trunctation instead of done
Note
This is quite confusing so please check this carefully and make sure I haven't mixed up where to use each one!
What?
Mostly explained in #951. We are mixing up termination and truncation. This is especially prevalent in recurrent systems, but all systems have this issue.
Now very explicit about termination vs truncation, removed all mentions of done. Done attribute remove from
RnnLearnerStateand replaced withtruncatedin thePpoTransition.How?
Explicitly name variables
terminationandtrunctationinstead ofdone