instadeepai / jumanji

🕹️ A diverse suite of scalable reinforcement learning environments in JAX
https://instadeepai.github.io/jumanji
Apache License 2.0
584 stars 71 forks source link

docs: update online doc with new environments #158

Closed clement-bonnet closed 1 year ago

clement-bonnet commented 1 year ago

fixes #155

clement-bonnet commented 1 year ago

Here is the current look of the readme Screenshot from 2023-06-05 18-58-44

TristanKalloniatis commented 1 year ago

Here is the current look of the readme Screenshot from 2023-06-05 18-58-44

Looks good, a couple quick questions:

  1. Some of the renderings look pretty similar, especially cleaner and maze. So in this view looks slightly odd IMO.
  2. I don't get the ordering in this collage
TristanKalloniatis commented 1 year ago

Is it purely alphabetical, ie not separated by env "type"? I ask because this is different from the order on the repo front page (in the table I mean)

clement-bonnet commented 1 year ago

Here is the current look of the readme Screenshot from 2023-06-05 18-58-44

Looks good, a couple quick questions:

  1. Some of the renderings look pretty similar, especially cleaner and maze. So in this view looks slightly odd IMO.
  2. I don't get the ordering in this collage
  1. Maze and Cleaner are under the hood using the same viewer abstraction, therefore they look similar indeed. I think it is even a good thing since you can show that things are easy to share. Either way, it is better to have all 18 environments that a selection that could make people think that only a few numbers of environments are implemented.
  2. Ordering is by alphabetic order (to mimic the paper).