instadeepai / jumanji

🕹️ A diverse suite of scalable reinforcement learning environments in JAX
https://instadeepai.github.io/jumanji
Apache License 2.0
583 stars 70 forks source link

fix: gh runners to use on-prem. #204

Closed callumtilbury closed 8 months ago

callumtilbury commented 1 year ago

As per @alaterre's request. I think I've done everything correctly—will check when the PR opens, as I can't run self-hosted CI jobs from my personal acc 😅

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

clement-bonnet commented 1 year ago

Hey! Thanks for the PR. Just wondering, why are we doing that?

callumtilbury commented 1 year ago

Hey @clement-bonnet! Alex has asked us to use self-hosted runners for all InstaDeep CI—perhaps he can clarify 👍🏻

clement-bonnet commented 1 year ago

Hey @clement-bonnet! Alex has asked us to use self-hosted runners for all InstaDeep CI—perhaps he can clarify 👍🏻

Thank you, @callumtilbury! Since this is a public and open-source project, I wonder if this is the right thing to do here. If I may ask, what is the reason to do so here?

callumtilbury commented 1 year ago

I wonder if this is the right thing to do here

It's a good question, @clement-bonnet. Still waiting to hear back from @alaterre.

In the interim, it's worth noting that the CI jobs aren't being picked up:

image

I may have made a syntax error somewhere, but the CI jobs are running on other ID projects.

clement-bonnet commented 8 months ago

@callumtilbury do we have an update on this? I'm closing this for now but please reopen if we have an update :)

callumtilbury commented 8 months ago

thanks @clement-bonnet! Following up with @alaterre now :)