Fixed mypy issues blocking pre-commit on python 3.9
Matplotlibs animation API seems to have changed in 3.8.x, so I pinned to 3.7.x (this was actually breaking all rendering as well as causing pre-commit issues)
Weird typing issue with JAX's dtype, I couldn't work it out so I added a type ignore :(
Jax typing issue
I anyone wants to try solve the jax issue instead of adding a type ignore:
The mypy error: jumanji/types.py:236: error: Returning Any from function declared to return "dtype[Any]" [no-any-return]
Seems like it thinks jnp.empty((), dtype).dtype returns Any, probably because jnp.empty(...) also returns Any, not really sure of a way around this :shrug:.
Changes
Fixed mypy issues blocking pre-commit on python 3.9
3.8.x, so I pinned to3.7.x(this was actually breaking all rendering as well as causing pre-commit issues)Jax typing issue
I anyone wants to try solve the jax issue instead of adding a type ignore:
The mypy error:
jumanji/types.py:236: error: Returning Any from function declared to return "dtype[Any]" [no-any-return]Seems like it thinks
jnp.empty((), dtype).dtypereturnsAny, probably becausejnp.empty(...)also returnsAny, not really sure of a way around this :shrug:.