Fix: issue in dtype of grid in cleaner env

instadeepai / jumanji

🕹️ A diverse suite of scalable reinforcement learning environments in JAX

https://instadeepai.github.io/jumanji

Apache License 2.0

583 stars 70 forks source link

Fix: issue in dtype of grid in cleaner env #217

Closed raphaelavalos closed 8 months ago

raphaelavalos commented 8 months ago

Hello,

I found a bug in the cleaner environment. The dtype of the grid was incorrect and it was failing the tests. The alternative fix would be to change the spec of the grid to int32.

Best, Raphael

CLAassistant commented 8 months ago

All committers have signed the CLA.

clement-bonnet commented 8 months ago

Hi @raphaelavalos, good catch, thank you! Indeed, the grid is of type int8. I am happy with your fix. However, it would be helpful if we could fix the documentation at the same time.

The Cleaner class docstring mentions int32 instead of int8 for the grid.
The documentation readme at docs/environments/cleaner.md shows int instead of int8.

Would you please be able to bring these changes as well? 🙏

raphaelavalos commented 8 months ago

Hi @clement-bonnet, I included the docstring and docs modifications 😄