search

instadeepai / marl-eval

A tool for aggregating and plotting MARL experiment data.
https://sites.google.com/view/marl-standard-protocol/home
Apache License 2.0
60 stars 6 forks source link

Number of steps not matching #33

Closed matteobettini closed 11 months ago

matteobettini commented 1 year ago

Wehn computing the number of steps here

https://github.com/instadeepai/marl-eval/blob/43f7d0a952c91187ff00702f94bafd423b7bcc99/marl_eval/utils/data_processing_utils.py#L230

-1 is subtracted to the actual number of steps even if there are no absolute metrics.

Is this expected? are users constrained to provide the "absolute_metrics" key?

RuanJohn commented 11 months ago

Hi @matteobettini, yes this is intended for now. We always assume that a user will be passing in an absolute_metrics key.

matteobettini commented 11 months ago

Got it thanks!