Errors are caught and not re-raised

instadeepai / marl-eval

A tool for aggregating and plotting MARL experiment data.

https://sites.google.com/view/marl-standard-protocol/home

Apache License 2.0

60 stars 6 forks source link

Errors are caught and not re-raised #35

Closed matteobettini closed 9 months ago

matteobettini commented 1 year ago

In the codebase, all exceptions are caught and replaced by custom print calls, like this https://github.com/instadeepai/marl-eval/blob/43f7d0a952c91187ff00702f94bafd423b7bcc99/marl_eval/utils/data_processing_utils.py#L303

this is not a good practice as:

it hides the stack trace to the user and debugging becomes impossible
it does not raise an error and the code gracefully executes
it assumes that the diagnosis class will be able to solve all possible exceptions

RuanJohn commented 11 months ago

Hi @matteobettini, thank you for raising this! I agree, this can definitely be improved. We will start working on it and let you know when we make some updates.