search

instadeepai / marl-eval

A tool for aggregating and plotting MARL experiment data.
https://sites.google.com/view/marl-standard-protocol/home
Apache License 2.0
57 stars 6 forks source link

Incorrect type returned from marl_eval.plotting_tools.plotting.probability_of_improvement #60

Open liamclarkza opened 5 months ago

liamclarkza commented 5 months ago

The function marl_eval.plotting_tools.plotting.probability_of_improvement(...) is defined to return a Matplotlib Figure but actually returns an Axes.

We can either update the type definition or modify the function to return the handle to the Figure. I think the latter is a better option. Happy to put in a PR for either.

liamclarkza commented 5 months ago

Same issue also exists for marl_eval.plotting_tools.plotting.sample_efficiency_curves and marl_eval.plotting_tools.plotting.plot_single_task